Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #3389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

VadimKudrenko
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Sum component with default values for a and b, ensuring it functions even when props are not provided! 🎉 The code meets all the task requirements and constraints, and the App component correctly uses the Sum component with various prop configurations. Keep up the excellent work! If you want to enhance your code further, consider ensuring that both a and b props are explicitly provided when necessary. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

{/* And remove commented lines :) */}
<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing the b prop. Ensure that both a and b props are provided to the Sum component if they are required.

<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />
<Sum b={5} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing the a prop. Ensure that both a and b props are provided to the Sum component if they are required.

<Sum a={-5} b={5} />
<Sum a={10} />
<Sum b={5} />
<Sum />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing both a and b props. Ensure that both a and b props are provided to the Sum component if they are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants