Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/accessibility/enhancement(featureDiscovery) initialization, accessibility and spec test #537

Merged

Conversation

gselderslaghs
Copy link
Member

@gselderslaghs gselderslaghs commented Dec 4, 2024

Proposed changes

Feature Discovery TapTarget trigger is not working as described in #523
This was caused by a bug where the initial triggering element was not handled within the event handler
In this fix I also addressed deleting the clone of the triggering element that initially handles closing the Feature Discover component by increasing the z-order on the initial trigger element and by a ternary operator to wether open/close the Feature Discovery when click event on this element is triggered

Multiple instances not programmatically being initialized #252
This also applies to #523 where a manual event handler needed to be defined in order to make the tap-targets work with the defined triggering element

Accessibility #541

  • Implemented keyboard interaction
  • Implemented aria-expanded
  • Implemented tab-index, this also works with child elements inside the tap target container

Implemented specification tests
Specification tests have been implemented based on initializing, opening and closing the Feature Discovery component

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gselderslaghs gselderslaghs changed the title fix(futureDiscovery) broken trigger #523 fix(featureDiscovery) broken trigger #523 Dec 4, 2024
@gselderslaghs gselderslaghs changed the title fix(featureDiscovery) broken trigger #523 fix(featureDiscovery) broken trigger Dec 4, 2024
@gselderslaghs
Copy link
Member Author

gselderslaghs commented Dec 8, 2024

This pull-request is still work in progress, as I've found that when using buttons or other tabbable content inside the component it's currently not possible to tab from the open/close triggering element directly to the elements inside the Tap Target container

@gselderslaghs
Copy link
Member Author

This pull-request is still work in progress, as I've found that when using buttons or other tabbable content inside the component it's currently not possible to tab from the open/close triggering element directly to the elements inside the Tap Target container

This was more of a local issue where the triggering element was placed in an additional wrapper instead of near the tap-target element itself

@gselderslaghs gselderslaghs changed the title fix(featureDiscovery) broken trigger fix/accessibility/enhancement(featureDiscovery) initialization, accessibility and spec test Dec 10, 2024
@gselderslaghs
Copy link
Member Author

Update:

Multiple instances not programmatically being initialized
This resolves that a manual event handler needed to be defined in order to make the tap-targets work with the defined triggering element

Accessibility

  • Implemented keyboard interaction
  • Implemented aria-expanded
  • Implemented tab-index, this also works with child elements inside the tap target container

Implemented specification tests
Specification tests have been implemented based on initializing, opening and closing the Feature Discovery component

This pull request is ready for review

…consistently since it was updated in setup in commit 6db4cc3
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io merged commit e4c6796 into materializecss:v2-dev Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants