Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Breadcrumb) allow basic variant without background color #589

Merged
merged 3 commits into from
Jan 30, 2025
Merged

fix(Breadcrumb) allow basic variant without background color #589

merged 3 commits into from
Jan 30, 2025

Conversation

gselderslaghs
Copy link
Member

@gselderslaghs gselderslaghs commented Jan 13, 2025 •
edited
Loading

Proposed changes

Fixes #573, dependent on #588

Changelog

  • Moved refactored breadcrumb variant to own component file
  • Fixed issue where breadcrumb rendered outside of nav was misaligned

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io merged commit c6269d1 into materializecss:v2-dev Jan 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuda-io wuda-io wuda-io approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gselderslaghs @wuda-io