-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[on hold ] Dark theme #35
base: develop
Are you sure you want to change the base?
Conversation
thanks a lot @hodovani for this contribution! (and sorry for the dealy; these days were very busy) I think a dark theme for materials cloud sounds like a great idea - we would just need to make it work across the website. Until that point: I saw that you modified the If you have suggestions on how to best go about that, they would be most welcome! |
@ltalirz thanks for links. I'll have a look at how we can use frontend-theme as a module :) |
@hodovani I brought up your suggestion in the Materials Cloud meeting and there were no objections - so we are free to go ahead and roll it out across Materials Cloud :-) However, as mentioned, this change will need to be made in the frontend-theme repository and then imported here. I'm usually programming in python, and the default package manager P.S. Happy new year! |
@ltalirz Sorry, creating a separate module with the styles would take more time than I have at the moment. I hope to return to this at some point in future... |
No worries, I also chatted with Evgeny - let's see whether someone from our team will find the time to do this refactoring at some point. |
The purpose of this PR is to add a dark theme to the app.
An example of dark theme:
An example of light theme:
A user can toggle theme with a button in menu: