-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml to resolve pip install issue #657
Changes from 23 commits
cb13eee
a167441
033f318
cda419c
83c97ec
e445eca
3137592
56fd836
fe4498b
660d438
b39fc3a
dd00bfb
14f1c0f
695f862
c165730
941ea87
b0fb265
fa9bd7b
f3d4023
c5209d1
ab8ebf8
1b433f8
1669ac5
206469e
bee8e97
5068c43
8c5f549
6d3b16d
d953c67
748cd9a
75cb1e7
fa4db5a
e67fd4d
291664a
7a7c6e8
be3ddfb
9dbe9e5
1a50d87
983c63f
15aca59
0dcb221
9bf4f51
39e1ce8
d29a7fc
2da756a
872de13
fc17348
db08783
df7368b
18b6cbd
4a44b67
40e2f76
5d4bd17
558d8bf
b105c39
37adfc3
936e4a4
ec39f56
7e6074d
4856415
eb2d5b3
228f256
d9b9e1e
c6bcb9a
4c4f999
84fa811
db84cb2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -68,14 +68,15 @@ where = ["src"] | |||||
"apps/pes/params/*.*", | ||||||
"describers/data/megnet_models/*", | ||||||
"describers/data/m3gnet_models/matbench_mp_e_form/0/m3gnet/*", | ||||||
"apps/pes/params/*.json", | ||||||
] | ||||||
|
||||||
[tool.black] | ||||||
line-length = 120 | ||||||
|
||||||
[tool.ruff] | ||||||
target-version = "py311" | ||||||
line-length = 120 | ||||||
line-length = 160 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider adhering to the PEP 8 recommended line length limit. The change increases the maximum allowed line length for the Allowing longer lines can make the code harder to read, maintain, and may lead to inconsistencies in code formatting across the project. Please consider reverting the change and adhering to the PEP 8 recommended line length limit of 79 characters: -line-length = 160
+line-length = 79 Committable suggestion
Suggested change
|
||||||
lint.select = [ | ||||||
"B", # flake8-bugbear | ||||||
"C4", # flake8-comprehensions | ||||||
|
@@ -112,6 +113,7 @@ lint.ignore = [ | |||||
"B028", # No explicit stacklevel keyword argument found | ||||||
"B904", # Within an except clause, raise exceptions with ... | ||||||
"C408", # unnecessary-collection-call | ||||||
"D103", # docstring is missing | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure all public functions have proper docstrings. The change ignores the pydocstyle error Ignoring the missing docstring error may lead to undocumented or poorly documented code, making it harder for other developers to understand and maintain the codebase. It may also lead to confusion and errors when using the functions without proper documentation. Please consider removing - "D103", # docstring is missing Committable suggestion
Suggested change
|
||||||
"D105", # Missing docstring in magic method | ||||||
"D205", # 1 blank line required between summary line and description | ||||||
"D212", # Multi-line docstring summary should start at the first line | ||||||
|
@@ -121,8 +123,10 @@ lint.ignore = [ | |||||
"PLR", # pylint refactor | ||||||
"PLW2901", # Outer for loop variable overwritten by inner assignment target | ||||||
"PT013", # pytest-incorrect-pytest-import | ||||||
"RET504", # assignment before `return` statement | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid assignments before The change ignores the ruff rule Ignoring this rule may lead to less readable and maintainable code. It can make the code harder to understand and reason about, and may introduce subtle bugs or unintended behavior that can be difficult to detect and debug. Please consider removing - "RET504", # assignment before `return` statement Committable suggestion
Suggested change
|
||||||
"RUF012", # Disable checks for mutable class args. This is a non-problem. | ||||||
"SIM105", # Use contextlib.suppress(OSError) instead of try-except-pass | ||||||
"SIM108", # Use ternary operator instead of `if`-`else`-block | ||||||
] | ||||||
lint.pydocstyle.convention = "google" | ||||||
lint.isort.required-imports = ["from __future__ import annotations"] | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Update required: Incorrect path specified in pyproject.toml
The path "apps/pes/params/.json" specified in pyproject.toml doesn't match the actual location of the JSON files in the repository. The correct path appears to be "src/maml/apps/pes/params/.json". Please update the pyproject.toml file with the correct path to ensure that the necessary JSON files are included in the package distribution.
On a positive note, no sensitive information was detected in any of the JSON files found in the repository.
Analysis chain
LGTM! This change resolves the reported installation issue.
The addition of
"apps/pes/params/*.json"
to thepackage-data
section ensures that the necessary JSON files are included in the package distribution when installing withpip install
. This should resolve theFileNotFoundError
that was occurring.Please verify that the JSON files in the
apps/pes/params
directory do not contain any sensitive information that should not be distributed with the package.Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 134
Script:
Length of output: 4518