New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `TypeError` and `AttributeError` in `is_ase_optimizer()` #19

Merged

janosh merged 3 commits into main from fix-is-ase-optim

Feb 19, 2024

Collaborator

janosh commented Feb 19, 2024

example failure cases:

attribute name must be string: is_ase_optimizer(ase.Calculator)
module 'ase.optimize' has no attribute 'whatever': is_ase_optimizer("whatever")

janosh added 3 commits

February 19, 2024 14:32


          Update pre-commit hooks

d59e5c3


          fix TypeError and AttributeError

1a00bea

- attribute name must be string
- module 'ase.optimize' has no attribute 'whatever'


          Add test for is_ase_optimizer()

5877dbb

janosh added fix ase labels

janosh merged commit b507e3a into main

2 checks passed

janosh deleted the fix-is-ase-optim branch

February 19, 2024 13:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ase fix