Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short script for computing charge density difference #58

Merged
merged 7 commits into from
Jul 17, 2024

Conversation

Sudo-Raheel
Copy link
Contributor

Summary

Major changes:

  • feature 1: ...
  • fix 1: ...

Todos

If this is work in progress, what else needs to be done?

  • feature 2: ...
  • fix 2:

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@Sudo-Raheel
Copy link
Contributor Author

I havent uploaded the CHGCAR files since these are very big ...should i create a new folder in CHGCAR_data inside the notebook directory

@shyuep
Copy link
Contributor

shyuep commented Jul 5, 2024

Yes pls put in the CHGCAR. you can just use a small example chgcar for demonstration. Maybe something with a very coarse resolution.

@shyuep
Copy link
Contributor

shyuep commented Jul 8, 2024

There is a failing tests about a scipy import for your notebook. Pls fix. You can ignore the rest of the error messages.

@Sudo-Raheel
Copy link
Contributor Author

Hi... Is there still some issue ?

@shyuep shyuep merged commit 2a02382 into materialsvirtuallab:master Jul 17, 2024
@shyuep
Copy link
Contributor

shyuep commented Jul 17, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants