feat: Synchronize Individual ESCs after playing back startup tune #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylesuxx
reviewed
Apr 14, 2021
js/bluejay_eeprom_layout.js
Outdated
| @@ -77,6 +77,8 @@ var BLHELI_LAYOUT = { | |||
| NAME: { offset: 0x60, size: 16 }, | |||
|
|
|||
| STARTUP_MELODY: { offset: 0x70, size: 128 } | |||
saidinesh5
force-pushed
the
startup_tunes_synchronize_wait
branch
from
3497e25 to
b9ff32d
Compare
Since we allow each ESC to set it's own startup tune, we can now automatically configure each of them to wait until all the others have finished playing their tune. The support for this is implemented using the new Eeprom variables in Bluejay: Eep_Pgm_Tune_Wait_MSB_ms - most significant byte Eep_Pgm_Tune_Wait_LSB_ms - least significant byte This should allow us to wait for 65536ms now. This should typically be enough for most usecases imo. If not, we can add another byte later on.
saidinesh5
force-pushed
the
startup_tunes_synchronize_wait
branch
from
b9ff32d to
be60112
Compare
saidinesh5
changed the title
OGCJM11
approved these changes
Dec 22, 2024
OGCJM11
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we allow each ESC to set it's own startup tune, we can now
automatically configure each of them to wait until all the others have
finished playing their tune.
The support for this is implemented using the new Eeprom variables in
Bluejay:
Eep_Pgm_Tune_Wait_MSB_ms - most significant byte
Eep_Pgm_Tune_Wait_LSB_ms - least significant byte
This should allow us to wait for 65536ms now.
This should typically be enough for most usecases imo. If not, we can
add another byte later on.
Requires: mathiasvr/bluejay#22