Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for version 3.5.0 #102

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Update for version 3.5.0 #102

merged 1 commit into from
Jan 3, 2022

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented Dec 13, 2021

  • make room for two additional annotation arrow styles (so that 'wedge' is show again)
  • add possibility to set tick labels together with tick positions

@jimustafa
Copy link
Contributor

Good catch with the arrow styles. Missed that when I had bumped the matplotlib version in #101. Looks like v3.5.0 added two arrow styles. Maybe we should be checking that the number of subplots is consistent with the number of styles, should more be added to matplotlib in the future.

@StefRe
Copy link
Contributor Author

StefRe commented Dec 14, 2021

@jimustafa As we don't have any unit tests here, we could do a "manual integration test" by comparing the png converted output before and after changing matplotlib versions.

As simple

compare https://web.archive.org/web/20211205002011im_/https://matplotlib.org/cheatsheets/_images/cheatsheets-2.png https://matplotlib.org/cheatsheets/_images/cheatsheets-2.png  diff.png

gives

diff

The webarchive version is of Dec 5, i.e. before merging #100, so diff.png also includes the cursive font fix, but it's just meant as an example to demonstrate the approach. (it also reveals some changes in the Garamond font of the bottom font example comparing small-caps vs normal, not sure where this comes from)

@rougier
Copy link
Member

rougier commented Dec 15, 2021

It's really nice to be able to compare like this.

- make room for two additional annotation arrow styles
- add possibility to set tick labels together with tick positions
@rougier
Copy link
Member

rougier commented Jan 3, 2022

@jimustafa Should we wait for your PR to be merged before mergin thos one or the other way around?

@jimustafa
Copy link
Contributor

@jimustafa Should we wait for your PR to be merged before mergin thos one or the other way around?

Free free to merge this one first. I can rebase #88, if necessary.

@rougier rougier merged commit 653fc62 into matplotlib:master Jan 3, 2022
@StefRe StefRe deleted the update_350 branch January 3, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants