Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter out the I codegen #140

Merged
merged 1 commit into from
Feb 1, 2025
Merged

fix: filter out the I codegen #140

merged 1 commit into from
Feb 1, 2025

Conversation

hedgar2017
Copy link
Collaborator

What ❔

  1. Filters out the I codegen.
  2. Brings back the narrow report formatting.

Why ❔

  1. It is not exposed to users, and was added only to get more test inputs.
  2. The new format is too wide for mobile devices.

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

@hedgar2017 hedgar2017 requested a review from a team February 1, 2025 06:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025 

Results for: evm

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025 

Results for: eravm  
╔═╡ Size (-%) ╞════════════╡ EVMInterpreter Y +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╠═╡ Cycles (-%) ╞══════════╡ EVMInterpreter Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞════════════╡ EVMInterpreter Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞════════════╡ EVMInterpreter Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs/gas ╞═════════════╡ EVMInterpreter Y +M3B3 ╞═╣
║ ADD                                          28.083 ║
║ MUL                                          16.850 ║
║ SUB                                          28.083 ║
║ DIV                                          19.250 ║
║ SDIV                                         36.050 ║
║ MOD                                          19.250 ║
║ SMOD                                         33.650 ║
║ ADDMOD                                       18.156 ║
║ MULMOD                                       16.656 ║
║ EXP                                           6.904 ║
║ SIGNEXTEND                                   19.250 ║
║ LT                                           32.083 ║
║ GT                                           32.083 ║
║ SLT                                          54.083 ║
║ SGT                                          54.083 ║
║ EQ                                           32.083 ║
║ ISZERO                                       27.750 ║
║ AND                                          28.083 ║
║ OR                                           28.083 ║
║ XOR                                          28.083 ║
║ NOT                                          23.750 ║
║ BYTE                                         38.083 ║
║ SHL                                          34.083 ║
║ SHR                                          34.083 ║
║ SAR                                          52.083 ║
║ SGT                                          54.083 ║
║ SHA3                                         25.073 ║
║ ADDRESS                                      41.812 ║
║ BALANCE                                      20.823 ║
║ ORIGIN                                     1351.625 ║
║ CALLER                                       41.812 ║
║ CALLVALUE                                    41.812 ║
║ CALLDATALOAD                                 26.083 ║
║ CALLDATASIZE                                 42.125 ║
║ CALLDATACOPY                                 49.492 ║
║ CODESIZE                                     45.625 ║
║ CODECOPY                                     61.472 ║
║ GASPRICE                                   1348.438 ║
║ EXTCODESIZE                                   3.605 ║
║ EXTCODECOPY                                   3.693 ║
║ RETURNDATASIZE                               43.500 ║
║ RETURNDATACOPY                               43.889 ║
║ EXTCODEHASH                                   4.641 ║
║ BLOCKHASH                                   238.819 ║
║ COINBASE                                   1348.625 ║
║ TIMESTAMP                                  1342.625 ║
║ NUMBER                                     1342.625 ║
║ PREVRANDAO                                 1342.625 ║
║ GASLIMIT                                   1348.625 ║
║ CHAINID                                    1336.625 ║
║ SELFBALANCE                                 639.250 ║
║ BASEFEE                                    1342.625 ║
║ POP                                          39.125 ║
║ MLOAD                                        43.667 ║
║ MSTORE                                       55.248 ║
║ MSTORE8                                      64.716 ║
║ SLOAD                                        18.930 ║
║ SSTORE                                        4.452 ║
║ JUMP                                         15.667 ║
║ JUMPI                                        15.636 ║
║ PC                                           42.312 ║
║ MSIZE                                        48.812 ║
║ GAS                                          42.312 ║
║ JUMPDEST                                     59.625 ║
║ PUSH0                                        42.312 ║
║ PUSH1                                        37.958 ║
║ PUSH2                                        43.375 ║
║ PUSH4                                        46.208 ║
║ PUSH5                                        47.625 ║
║ PUSH6                                        49.042 ║
║ PUSH7                                        50.458 ║
║ PUSH8                                        51.875 ║
║ PUSH9                                        53.292 ║
║ PUSH10                                       54.708 ║
║ PUSH11                                       56.125 ║
║ PUSH12                                       57.542 ║
║ PUSH13                                       58.958 ║
║ PUSH14                                       60.375 ║
║ PUSH15                                       61.792 ║
║ PUSH16                                       63.208 ║
║ PUSH17                                       64.625 ║
║ PUSH18                                       66.042 ║
║ PUSH19                                       67.458 ║
║ PUSH20                                       68.875 ║
║ PUSH21                                       70.292 ║
║ PUSH22                                       71.708 ║
║ PUSH23                                       73.125 ║
║ PUSH24                                       74.542 ║
║ PUSH25                                       75.958 ║
║ PUSH26                                       77.375 ║
║ PUSH27                                       78.792 ║
║ PUSH28                                       80.208 ║
║ PUSH29                                       81.625 ║
║ PUSH30                                       83.042 ║
║ PUSH31                                       84.458 ║
║ PUSH32                                       85.875 ║
║ DUP1                                         26.083 ║
║ DUP2                                         32.417 ║
║ DUP3                                         32.417 ║
║ DUP4                                         32.417 ║
║ DUP5                                         32.417 ║
║ DUP6                                         32.417 ║
║ DUP7                                         32.417 ║
║ DUP8                                         32.417 ║
║ DUP9                                         32.417 ║
║ DUP10                                        32.417 ║
║ DUP11                                        32.417 ║
║ DUP12                                        32.417 ║
║ DUP13                                        32.417 ║
║ DUP14                                        32.417 ║
║ DUP15                                        32.417 ║
║ DUP16                                        32.417 ║
║ SWAP1                                        32.417 ║
║ SWAP2                                        32.417 ║
║ SWAP3                                        32.417 ║
║ SWAP4                                        32.417 ║
║ SWAP5                                        32.417 ║
║ SWAP6                                        32.417 ║
║ SWAP7                                        32.417 ║
║ SWAP8                                        32.417 ║
║ SWAP9                                        32.417 ║
║ SWAP10                                       32.417 ║
║ SWAP11                                       32.417 ║
║ SWAP12                                       32.417 ║
║ SWAP13                                       32.417 ║
║ SWAP14                                       32.417 ║
║ SWAP15                                       32.417 ║
║ SWAP16                                       32.417 ║
║ CALL                                         33.875 ║
║ STATICCALL                                   33.852 ║
║ DELEGATECALL                                 32.920 ║
║ CREATE                                        3.703 ║
║ CREATE2                                       4.994 ║
║ RETURN                                       33.645 ║
║ REVERT                                       33.742 ║
╠═╡ Ergs/gas (-%) ╞════════╡ EVMInterpreter Y +M3B3 ╞═╣
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════════╡ EVMInterpreter Y +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╠═╡ Cycles (-%) ╞══════════╡ EVMInterpreter Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞════════════╡ EVMInterpreter Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞════════════╡ EVMInterpreter Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All E +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All E +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All V +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All V +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All V +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All V +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All V +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All V +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All V +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All V +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═══════════════════════╡ All Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════╡ Precompiles NoCodegen M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞══════╡ Precompiles NoCodegen M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞════════╡ Precompiles NoCodegen M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞════════╡ Precompiles NoCodegen M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════╡ Precompiles NoCodegen MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞══════╡ Precompiles NoCodegen MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞════════╡ Precompiles NoCodegen MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞════════╡ Precompiles NoCodegen MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life E +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life V +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life V +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life V +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life V +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life V +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life V +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life V +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life V +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +M3B3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╗
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Cycles (-%) ╞═══════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠═╡ Ergs (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                         0.000 ║
╠══╡ Gas (-%) ╞═════════════════╡ Real life Y +MzB3 ╞═╣
║ Best                                          0.000 ║
║ Worst                                         0.000 ║
║ Total                                           NaN ║
╚═════════════════════════════════════════════════════╝

@hedgar2017 hedgar2017 enabled auto-merge (squash) February 1, 2025 08:14
@hedgar2017
Copy link
Collaborator Author

hedgar2017 commented Feb 1, 2025 •
edited
Loading

Hey @antonbaliasnikov @sayon, do you know why the EVM report is empty?

@sayon
Copy link
Contributor

sayon commented Feb 1, 2025

No -- I'll check what's wrong tonight

@hedgar2017
Copy link
Collaborator Author

No -- I'll check what's wrong tonight

In the LLVM repo it's fine, so perhaps the CI here wasn't updated,

@hedgar2017
Copy link
Collaborator Author

No -- I'll check what's wrong tonight

Please review/approve anyway!

@hedgar2017 hedgar2017 merged commit 7d0886e into main Feb 1, 2025
12 checks passed
@hedgar2017 hedgar2017 deleted the az-filter-out-i-codegen branch February 1, 2025 23:52
@antonbaliasnikov
Copy link
Contributor

Hey @antonbaliasnikov @sayon, do you know why the EVM report is empty?

hmm, interesting. I'll check what's wrong in the tester repo.

antonbaliasnikov pushed a commit that referenced this pull request Feb 3, 2025
@hedgar2017 @antonbaliasnikov
fix: filter out the I codegen (#140)
7a64ba1
antonbaliasnikov pushed a commit that referenced this pull request Feb 3, 2025
@hedgar2017 @antonbaliasnikov
fix: filter out the I codegen (#140)
4617422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayon sayon sayon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hedgar2017 @sayon @antonbaliasnikov