fix: failing far call tracing #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be fine performance-wise, as creating new frames has become much cheaper with the recycling of stacks.
slowli
previously approved these changes
Jan 22, 2025
slowli
approved these changes
Jan 23, 2025
joonazan
pushed a commit
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.1...v0.3.0) (2025-01-27) ### ⚠ BREAKING CHANGES * Remove EVM emulator gas stipend ([#82](#82)) * Revise VM storage interface ([#73](#73)) ### Features * Allow customizing precompiles logic ([#79](#79)) ([3841f5a](3841f5a)) * allow tracers to stop/suspend execution ([#78](#78)) ([457d8a7](457d8a7)) * expose storage to tracers ([#77](#77)) ([df5bec3](df5bec3)) ### Bug Fixes * **ci:** Update github-hosted runner label ([#80](#80)) ([70a6e30](70a6e30)) * failing far call tracing ([#81](#81)) ([5df8c33](5df8c33)) * Remove EVM emulator gas stipend ([#82](#82)) ([bf63339](bf63339)) * Revise VM storage interface ([#73](#73)) ([a233d44](a233d44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tracing so that a failed far call reports a far call and then a panic to tracers instead of reporting the panic in the middle of the far call.