-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Mattermost Plugins E2E Utils as a dependency #258
base: master
Are you sure you want to change the base?
Adding the Mattermost Plugins E2E Utils as a dependency #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @panoramix360!! This is awesome that we're now connecting the dots between this repo and mattermost-community/mattermost-plugin-e2e-test-utils#3. This is going to be so awesome using this here! 🚀
Next steps here are to adapt the code in e2e/playwright
folder that is related to the obsolete configuration:
support/init_test.ts
should set up stuff for themattermost-plugin-e2e-test-utils
package usage- Things from
support
should be transferred to the shared package for reuse by other plugins setup-environment
can be removed- Any functionality imported from
@e2e-support/*
should be relocated to the shared package. This includes thetest
function which is a modification of playwright'stest
function, supported by playwright'stest.extend
function. It may be easiest to explain this plan on a video call https://github.com/mattermost/mattermost/blob/659377395915ae19c3548930cd450102280b9f9f/e2e-tests/playwright/support/test_fixture.ts#L25
Please let me know of any questions you may have, and if you feel a video call would be most efficient to discuss this. Thanks so much @panoramix360! Great job!!
From my comment above:
I'm thinking a lot of this stuff is already in the shared package. If there's anything else that this |
hey @mickmister and @jespino! Happy new year! Sorry for the delay on this, I'll resume working on that to try to implement this on the repo. Let you know if I need any help, I was having an issue with the Thanks! |
46c38bb
to
2aa5c91
Compare
Co-authored-by: Michael Kochell <[email protected]>
2aa5c91
to
b62af71
Compare
This PR is intended to test the integration with the Mattermost Plugins E2E Utils that I'm working on with @mickmister!
I'm creating as a draft for now, so we can test it.
Related PR in
mattermost-plugin-e2e-test-utils
repomattermost-community/mattermost-plugin-e2e-test-utils#3
Related thread
https://community.mattermost.com/core/pl/w4oistz7rtn4bj9ewfu8neimdh