Apply and enforce file-level license headers #440
+371
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
force-pushed
the
updated-license-header
branch
from
6b1a3ad to
763da60
Compare
Use `mattermost-govet` to ensure each file begins with the appropriate header, then fix all instances for built source code. ``` // Copyright (c) 2019-present Mattermost, Inc. All Rights Reserved. // See LICENSE.txt for license information. ``` Note that this renames `LICENSE` to `LICENSE.txt` purely to align on the copyright messaging across repos.
lieut-data
force-pushed
the
updated-license-header
branch
from
763da60 to
6c72240
Compare
lieut-data
force-pushed
the
updated-license-header
branch
from
f573fb9 to
f13d253
Compare
wiggin77
reviewed
Jan 29, 2025
wiggin77
reviewed
Jan 29, 2025
wiggin77
reviewed
Jan 29, 2025
wiggin77
reviewed
Jan 29, 2025
|
@lieut-data a bunch of files ended up with duplicated copyright notices with different dates. I commented on the first few I found, but didn't comment on the rest. Is the tool meant to detect existing copyright messages and update or replace them? |
|
Thanks for your careful eye, @wiggin77! I thought I had pruned the cases where this had occurred early on, but I clearly wasn't rigorous enough. I've gone through all the pre-packaged plugins again to check for duplicate Copyrights and fixed the ones here as well as in the Jira PR. (I've also surfaced some weird files in Boards I'm looking into separately.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
mattermost-govetto ensure each file begins with the appropriate header, then fix all instances for built source code.Note that this renames
LICENSEtoLICENSE.txtpurely to align on the copyright messaging across repos.Ticket Link
None