-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite macros and tests, add generators #2
base: master
Are you sure you want to change the base?
Rewrite macros and tests, add generators #2
Conversation
906a9ca
to
468452e
Compare
Docs need some more work, but the previous ones were pretty much just a copy-paste of the tests which seemed like bad form.
468452e
to
9a9de7a
Compare
Hi @JustANull thanks a lot for this PR, that's a lot of work!! I like what you've done but I can't merge it since the PR has a lot going and does not meet the criteria below:
I think, a good approach would be to submit several PRs, each having a single responsibility. It would be easy to reason about them and make merging straight forward. Checkout this awesome guide. Let me how this sounds to you. I'm happy to help you break up this PR into smaller ones. |
Also I'm curious why are some of the previous tests were deleted. Is there a reason for this? |
There's an open issue for generator comprehensions support. May be you can use that for the generator support work. |
This got a bit out of hand because it basically ends up as a complete rewrite of the original macros and tests. I can't really break it up into multiple PRs easily because all of the code is shaped by the Originally, the docs didn't wrap the examples with The original Adding the Finally, under the new macro structure that supports |
Docs need some more work, the previous ones were almost a copy-paste of the tests which seemed like bad form. They also didn't pass
cargo test
, so I added harnesses to make them pass properly, and updated the README to include the documentation as updated from the start of the file.The macros themselves could use some documentation.