Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process chunk from buffer in final step when assembling tweet chunks #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sandhu
Copy link

@sandhu sandhu commented Dec 25, 2014

In the final step the buff will contain the last chunk. The final step now ensures that the left over chunk is processed.

In the final step any the buff will contain the last chunk. The final
step now ensures that the left over chunk is processed.
@matthiasn
Copy link
Owner

Hey Sandhu, thank you for the pull request and sorry for not getting around to it sooner. I will check it later this week and see if I can merge it. However, this condition doesn't really appear where the left over chunk needs to be processed does not really occur because there's an ongoing stream. When the application is closed, it hardly matters if there's probably another full item in there. Even if, when I quit I'm going to miss data from some point on. The application is really meant to be kept running. Cheers, Matthias

@sandhu
Copy link
Author

sandhu commented Jan 21, 2015

No worries on the delay Matthias. I definitely agree with your comment that the issue will not be observed in the scenario the transducer is being used in this particular application, however if you wanted to use this transducer with a vector you'd see the issue.

Since the transducer represents an abstracted computation outside the specific scenario of a particular application to data, I created the PR.

Cheers,
Achint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants