[feat] Formatting for numeric columns (vctrs) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattle24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to create a vctrs class
googlesheets4_format_numberand associated methods for handling number formats, similar togooglesheets4_formula.Meant to address tidyverse#81 (although I forgot that issue was specifically about dates not numbers so this PR is a little off base), also touches on the number format question in tidyverse#179.
I'm thinking about this as a building point for other additions to also handle
These four functionalities are an important part of our workflows, and solutions with
googlesheets4will help us automate our pipelines. If these fit ingooglesheets4that would be ideal, otherwise we can stick them in internal packages.