Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] inspect.getargspec is deprecated in Python 3.6 #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bug Fix] inspect.getargspec is deprecated in Python 3.6 #52

wants to merge 1 commit into from

Conversation

mikigom
Copy link

@mikigom mikigom commented Jun 6, 2023

This PR would solve the previous issue #51.

jinzishuai
jinzishuai approved these changes Oct 12, 2023
View reviewed changes
Copy link

@jinzishuai jinzishuai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the right fix and I validated that this fix works on my Mac M2 using python 3.11

@jinzishuai
Copy link

@mattloper could you please merge this? It breaks in python 3.11.

@apoorvagnihotri
Copy link

Please merge this, this works fine.

@palonekdaniel
Copy link

Please merge this, this works fine.

You can install chumpy with fixed version by applying the commit from PR
#59
or the one in this thread.

Just use:

pip install git+https://github.com/mattloper/chumpy@9b045ff5d6588a24a0bab52c83f032e2ba433e17

@penguinflys
Copy link

Please merge it. It will make many lives easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinzishuai jinzishuai jinzishuai approved these changes

@palonekdaniel palonekdaniel palonekdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikigom @jinzishuai @apoorvagnihotri @palonekdaniel @penguinflys