Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove FTDI from USB pid/vid list for SiK Radio #12277

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

dakejahl
Copy link
Contributor

@dakejahl dakejahl commented Jan 3, 2025

Useful to debug an MCU while also using QGC. I don't think we should identify FTDI devices as SiK Radios and attempt to autoconnect as such.

@DonLakeFlyer
Copy link
Contributor

The question is what radio setup is this exactly. Both 3DR radio entires are identified as 1027 which is FTDI manufacturer. It's all kind of ancient history. Is it really some obscure setup which is rarely used?

@dakejahl
Copy link
Contributor Author

dakejahl commented Jan 3, 2025

The Holybro SiK radios I have here identify as 0403:6015 which corresponds to that other 3DR Radio entry.

0403:6015 Future Technology Devices International, Ltd Bridge(I2C/SPI/UART/FIFO)
{ "vendorID": 1027, "productID": 24597,     "boardClass": "SiK Radio",  "name": "SiK Radio",            "comment": "3DR Radio" },

Whereas the one I removed corresponds to the basic USB UART converter. One other thing I noticed a while back is that if you have SiK Radio autoconnect enabled you can't create a mavlink connection using the Comm Links page on that interface since it is trying to autoconnect to it as a SiK Radio which uses a default 57600 baudrate. If your link (let's say a pixhawk telem port) isn't at 57600 it won't autoconnect and you can't connect with the Comm Links, you have to know to go and untick the sik radio autoconnect box which is default enabled.

Anyway, I guess what I'm getting at it can be a little confusing depending on what you're trying to do if you're not aware of this. IMO if someone has a SiK radio that identifies as an generic USB UART converter I think they should just manually create a comm link.

@DonLakeFlyer
Copy link
Contributor

Yeah, I think I can live with that.

@DonLakeFlyer DonLakeFlyer merged commit 8a802eb into master Jan 3, 2025
8 checks passed
@DonLakeFlyer DonLakeFlyer deleted the pr-reclaim_ftdi branch January 3, 2025 21:48
@DonLakeFlyer
Copy link
Contributor

One other thing I noticed a while back is that if you have SiK Radio autoconnect enabled you can't create a mavlink connection using the Comm Links page on that interface since it is trying to autoconnect to it as a SiK Radio which uses a default 57600 baudrate.

I think this could possibly be fixed at least to the point of letting the user know that they need to turn off autoconnect. You should be able to detect trying to connect to something which is already auto-connected to. Shouldn't be too hard...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants