Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vimtex integration #9

Merged
merged 12 commits into from
Jan 31, 2025
Merged

feat: add vimtex integration #9

merged 12 commits into from
Jan 31, 2025

Conversation

Vinzent03
Copy link
Contributor

This pr adds an integration for the vimtex plugin. This adds quite more keymaps than the other integrations, and it's more complicated to simulate the original key press, because it does not provide a lua interface.
So I'm curious what you think about this integration.

For me, a nice addition with this integration is a better description in which-key, because it now shows the actual action and not just vimtex-]]).

Copy link
Owner

@mawkler mawkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. And thank you for providing great documentation!

Could you also add these two things to the README.md please?

  1. Update the configuration table in the default options so that it includes the vimtex options
  2. Add a Vimtex section to Usage with a table with mappings and explanations

Could you also make sure that you use 's instead of " for your strings for formatting consistency?

lua/demicolon/integrations/vimtex.lua Outdated Show resolved Hide resolved
lua/demicolon/integrations/vimtex.lua Outdated Show resolved Hide resolved
@Vinzent03
Copy link
Contributor Author

Great, all your requested changes should be implemented.
Additionally, I've fixed the keymap for comment end and changed the mode to normal only, because I couldn't get it to work in operator pending mode.

@mawkler
Copy link
Owner

mawkler commented Jan 31, 2025

Awesome!

Yeah that's odd that the operator pending-mapping doesn't work, I tried it as well. Perhaps we should keep the visual mode mapping as well ('x')? That one seems to work

@Vinzent03
Copy link
Contributor Author

Oh yeah you are right. I've added it back in. I've also added a note to the readme.

@mawkler
Copy link
Owner

mawkler commented Jan 31, 2025

Great work! Thank you very much for your contribution!

@mawkler mawkler merged commit ef477e1 into mawkler:main Jan 31, 2025
@Vinzent03 Vinzent03 deleted the feat/vimtex branch January 31, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants