Handle exception setting console encoding

maxim-zhao · Dec 24, 2021 · ba6f118 · ba6f118
1 parent 37c1c16
commit ba6f118
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 12 deletions.
diff --git a/LibSidWiz/LibSidWiz.csproj b/LibSidWiz/LibSidWiz.csproj
@@ -9,9 +9,10 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>LibSidWiz</RootNamespace>
     <AssemblyName>LibSidWiz</AssemblyName>
-    <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <Deterministic>true</Deterministic>
+    <TargetFrameworkProfile />
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>

diff --git a/LibSidWiz/Outputs/FfmpegOutput.cs b/LibSidWiz/Outputs/FfmpegOutput.cs
@@ -33,8 +33,16 @@ public FfmpegOutput(string pathToExe, string filename, int width, int height, in
 
             Console.WriteLine($"Starting FFMPEG: {pathToExe} {arguments}");
 
-            // We don't want a BOM to be injected if the system code page is set to UTF-8
-            Console.InputEncoding = Encoding.ASCII;
+            // We don't want a BOM to be injected if the system code page is set to UTF-8.
+            // This fails sometimes, so we swallow the error...
+            try
+            {
+                Console.InputEncoding = Encoding.ASCII;
+            }
+            catch (Exception e)
+            {
+                Console.WriteLine($"Failed to change console encoding to ASCII. You may get video corruption. Exception said: {e.Message}");
+            }
 
             // Start it up
             _process = Process.Start(

diff --git a/SidWiz/Properties/Resources.Designer.cs b/SidWiz/Properties/Resources.Designer.cs
diff --git a/SidWiz/SidWizPlusGUI.csproj b/SidWiz/SidWizPlusGUI.csproj
@@ -10,7 +10,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>SidWizPlusGUI</RootNamespace>
     <AssemblyName>SidWizPlusGUI</AssemblyName>
-    <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
     <TargetFrameworkProfile>
     </TargetFrameworkProfile>
     <FileAlignment>512</FileAlignment>

diff --git a/SidWiz/app.config b/SidWiz/app.config
@@ -1,12 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
-
 <configuration>
   <runtime>
-    <gcAllowVeryLargeObjects enabled="true" />
+    <gcAllowVeryLargeObjects enabled="true"/>
     <!-- AppContextSwitchOverrides value attribute is in the form of 'key1=true|false;key2=true|false  -->
-    <AppContextSwitchOverrides value="Switch.UseLegacyAccessibilityFeatures=false" />
+    <AppContextSwitchOverrides value="Switch.UseLegacyAccessibilityFeatures=false"/>
   </runtime>
   <startup>
-    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.1" />
+    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8"/>
   </startup>
 </configuration>
diff --git a/SidWizPlus/App.config b/SidWizPlus/App.config
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <configuration>
     <startup> 
-        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7.2"/>
+        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8"/>
     </startup>
 </configuration>
diff --git a/SidWizPlus/Properties/Resources.Designer.cs b/SidWizPlus/Properties/Resources.Designer.cs
diff --git a/SidWizPlus/SidWizPlus.csproj b/SidWizPlus/SidWizPlus.csproj
@@ -8,7 +8,7 @@
     <OutputType>Exe</OutputType>
     <RootNamespace>SidWizPlus</RootNamespace>
     <AssemblyName>SidWizPlus</AssemblyName>
-    <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
     <Deterministic>true</Deterministic>