Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port C FFI crate to maybenot-v2 #28

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Port C FFI crate to maybenot-v2 #28

merged 1 commit into from
Oct 24, 2024

Conversation

hulthe
Copy link
Contributor

@hulthe hulthe commented Aug 13, 2024

Port the maybenot-ffi crate from v1 to v2, and expose the new events and actions.

This port simply uses the std::time types, but we may want to consider using something else. If it's possible to use a no_std time implementation, that would be preferable as it avoids linking rust std into the resulting static lib.

@hulthe
Copy link
Contributor Author

hulthe commented Aug 13, 2024

As of right now, this compiles, but hasn't been thoroughly tested. Therefore I'm leaving this as a draft PR until we get around to doing that.

@pylls
Copy link
Contributor

pylls commented Aug 13, 2024

Many thanks @hulthe ! Let me know when you think it's in a good shape.

@pylls
Copy link
Contributor

pylls commented Sep 9, 2024

Hi again, @hulthe. This is just a request for when you finish this PR: please also update the root repository README.md to include a link to this crate (like it was in v1). In getting v2.0 out there, I temporarily removed it since the v2 (now new main) branch started before v1 of the FFI crate was there.

@hulthe hulthe force-pushed the ffi-v2 branch 3 times, most recently from 850e665 to a509518 Compare October 21, 2024 13:00
@hulthe hulthe marked this pull request as ready for review October 21, 2024 13:07
@hulthe
Copy link
Contributor Author

hulthe commented Oct 21, 2024

@pylls We've tested this and think it's ready to be merged and published now :)

@faern faern merged commit 5bd41c7 into maybenot-io:main Oct 24, 2024
7 checks passed
@faern
Copy link
Collaborator

faern commented Oct 24, 2024

I went ahead and merged this, since we are happy with this FFI. @pylls are you able to publish this update to maybenot-ffi to crates.io?

@pylls
Copy link
Contributor

pylls commented Oct 24, 2024

Excellent, thank you all! Sorted.

@hulthe hulthe deleted the ffi-v2 branch October 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants