Fixing interstitial directory prefix

[hitarth64]

Found this issue where the directories generated for interstitials begin with 'Int_' but pycdt looks for matches that begin with 'inter_'. Updated the 3 instances where this happens and that fixes everything.

[mbkumar]

Hello Hitarth,

If you look at https://github.com/mbkumar/pycdt/blob/master/pycdt/core/defectsmaker.py:744, we are using 'inter' for interstitials. Not sure how you got 'Int' in the folder names. Did you generate the input files by yourself?

[hitarth64]

Hi Bharat,

Thank you for your reply. I am using a combination of pycdt(2.0.2) and pymatgen(2019.5.28) on python 3.6.

To cross-check, I tried generating the input structures again (using *pycdt generate_input --structure_file POSCAR --include_interstitial Pb) and found that all the directories for interstitials are still prefixed with 'Int_'. Maybe it's just this particular combination of library versions that makes this problem pop up? Thanks!

[mbkumar]

Could you please post your POSCAR? I'd like to debug this issue in detail. Lot of pycdt code got pushed into pymatgen by others and there might be some inadvertent discrepancies in the way things are processed now.

…

On Fri, Dec 13, 2019 at 10:35 PM Hitarth Choubisa ***@***.***> wrote: Hi Bharat, Thank you for your reply. I am using a combination of pycdt(2.0.2) and pymatgen(2019.5.28) on python 3.6. To cross-check, I tried generating the input structures again (using *pycdt generate_input --structure_file POSCAR --include_interstitial Pb) and found that all the directories for interstitials are still prefixed with 'Int_'. Maybe it's just this particular combination of library versions that makes this problem pop up? Thanks! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=AA62VEFT264X56OGH2NHCQLQYRIAXA5CNFSM4J2JQM7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3ZA6I#issuecomment-565678201>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA62VEGRVYFHPFUM6GTZYLTQYRIAXANCNFSM4J2JQM7A> .

-- Bharat Medasani Computational Scientist Delaware Energy Institute University of Delaware

[hitarth64]

Hi Bharat, Here is the link to corresponding POSCAR - https://github.com/hitarth64/pycdt/blob/master/examples/POSCAR

Thanks!