Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Start LAMP Ad-Hoc Task with Github #443

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

rymarczy
Copy link
Collaborator

This change allows LAMP Ad-Hoc ECS Task to be triggered with github action.

Ad-Hoc ECS Task created by devops PR: https://github.com/mbta/devops/pull/2184

Asana Task: https://app.asana.com/0/1205827492903547/1207556073650893

@rymarczy rymarczy requested a review from arkadyan September 24, 2024 20:03
Copy link

@arkadyan arkadyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I assume the devops PR should go first before this gets merged?

VPC_NAME="vpc-dev-ctd-itd"
elif [ "$ENVIRONMENT" == "prod" ]; then
VPC_NAME="vpc-prod-ctd-itd"A

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rymarczy
Copy link
Collaborator Author

👍

I assume the devops PR should go first before this gets merged?

Yup, I will wait to merge until the devops PR has been fully closed!

@rymarczy
Copy link
Collaborator Author

After thinking about this overnight, I realized I needed to be able to deploy the ad-hoc task as well as run it. And, to me, it makes sense that the deploy and run would be coupled for a task of this nature. So I created a new github action that deploys and runs the ad-hoc task as it's own workflow.

@rymarczy rymarczy requested a review from arkadyan September 25, 2024 12:25
Copy link

@arkadyan arkadyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense

@rymarczy rymarczy merged commit 31a5082 into main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants