Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use encrypted DB connection, for real this time #787

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

jzimbel-mbta
Copy link
Member

Summary of changes

Asana Ticket: -

Followup to #785 and #786.

Dev deploy is succeeding.

👉 Here are the overall changes across these 3 PRs. 👈

(I'm not sure why all the other repos do a complicated multi-step dance of downloading the certfile to one image and then copying it one or more times through to the final image. You can just download it directly to priv/ right before compiling and releasing. 🤷‍♂️)

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)

@jzimbel-mbta jzimbel-mbta requested review from a team and lemald and removed request for a team January 15, 2025 18:10
@lemald
Copy link
Member

lemald commented Jan 15, 2025

(I'm not sure why all the other repos do a complicated multi-step dance of downloading the certfile to one image and then copying it one or more times through to the final image. You can just download it directly to priv/ right before compiling and releasing. 🤷‍♂️)

At least in the case of Skate, I just didn't know Docker very well at the time and therefore didn't do it in a very efficient way. 😅

@jzimbel-mbta
Copy link
Member Author

At least in the case of Skate, I just didn't know Docker very well at the time and therefore didn't do it in a very efficient way. 😅

I didn't know Docker well enough to understand why the extra steps weren't necessary until I was forced to go look things up to fix my mistakes, so no worries!

@jzimbel-mbta jzimbel-mbta merged commit 6d1b642 into master Jan 15, 2025
39 checks passed
@jzimbel-mbta jzimbel-mbta deleted the jz-encrypted-db-connection-take-3 branch January 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants