Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update GitHub actions to use assumed role #2264

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Chore: Update GitHub actions to use assumed role #2264

merged 1 commit into from
Oct 23, 2023

Conversation

krisrjohnson21
Copy link
Contributor

This PR updates the deploy workflow to use v2 of the shared build-push-ecr and deploy-ecs actions. These updated actions assume an IAM role instead of relying on long-lasting AWS keys for an IAM user

Successful dev deploy here

@krisrjohnson21 krisrjohnson21 requested review from a team and ianwestcott October 23, 2023 17:52
@krisrjohnson21 krisrjohnson21 requested a review from a team as a code owner October 23, 2023 17:52
@github-actions
Copy link

Coverage of commit c902ef0

Summary coverage rate:
  lines......: 94.8% (2992 of 3156 lines)
  functions..: 74.6% (1254 of 1682 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack temporarily deployed to dev-green October 23, 2023 18:01 — with GitHub Actions Inactive
firestack
firestack reviewed Oct 23, 2023
View reviewed changes
.github/workflows/deploy-base.yml
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
aws-region: us-east-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is this equivalent to setting AWS_DEFAULT_REGION?

Copy link
Contributor Author

@krisrjohnson21 krisrjohnson21 Oct 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's right! When AWS configures credentials, it requires a region which it then passes down to any subsequent AWS actions throughout the rest of the workflow

firestack
firestack reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Doesn't seem like there are any issues with deploying to dev-green.

@krisrjohnson21 krisrjohnson21 merged commit 99e7509 into master Oct 23, 2023
8 checks passed
@krisrjohnson21 krisrjohnson21 deleted the github-actions-krj branch October 23, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

@ianwestcott ianwestcott ianwestcott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisrjohnson21 @ianwestcott @firestack