Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old search mode code #2350

Merged
merged 12 commits into from
Jan 5, 2024
Merged

Remove old search mode code #2350

merged 12 commits into from
Jan 5, 2024

Conversation

lemald
Copy link
Member

@lemald lemald commented Jan 4, 2024

Asana ticket: Remove the code

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Coverage of commit 32d73e6

Summary coverage rate:
  lines......: 94.6% (3048 of 3222 lines)
  functions..: 73.0% (1244 of 1704 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Coverage of commit cb095ca

Summary coverage rate:
  lines......: 94.6% (3048 of 3222 lines)
  functions..: 73.0% (1244 of 1704 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Coverage of commit 5a812f8

Summary coverage rate:
  lines......: 94.6% (3035 of 3209 lines)
  functions..: 72.9% (1243 of 1704 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate_web/channels/vehicles_channel.ex                      |95.8%     24|81.8%    11|    -      0

Download coverage report

@lemald lemald force-pushed the lem-remove-old-maps-code branch from ec0803d to de7cb8a Compare January 4, 2024 20:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Coverage of commit de7cb8a

Summary coverage rate:
  lines......: 94.5% (3016 of 3191 lines)
  functions..: 72.9% (1239 of 1700 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/realtime/server.ex                                          |99.2%    132|97.8%    45|    -      0
  lib/skate_web/channels/vehicle_channel.ex                       | 100%     20|80.0%    10|    -      0
  lib/skate_web/channels/vehicles_channel.ex                      |95.8%     24|81.8%    11|    -      0
  lib/skate_web/channels/vehicles_search_channel.ex               |92.3%     26| 100%    12|    -      0

Download coverage report

@lemald lemald marked this pull request as ready for review January 4, 2024 20:25
@lemald lemald requested a review from a team as a code owner January 4, 2024 20:25
@lemald
Copy link
Member Author

lemald commented Jan 4, 2024

Oh @mbta/skate-developers I should have specified in the description but this should hopefully be reviewable commit-by-commit (though admittedly the first commit on its own is still quite large).

firestack
firestack approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know if #2350 (comment) is possible, but other than that, LGTM 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Coverage of commit 20c57b8

Summary coverage rate:
  lines......: 94.5% (3016 of 3191 lines)
  functions..: 72.9% (1239 of 1700 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/realtime/server.ex                                          |99.2%    132|97.8%    45|    -      0
  lib/skate_web/channels/vehicle_channel.ex                       | 100%     20|80.0%    10|    -      0
  lib/skate_web/channels/vehicles_channel.ex                      |95.8%     24|81.8%    11|    -      0
  lib/skate_web/channels/vehicles_search_channel.ex               |92.3%     26| 100%    12|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Coverage of commit 696c982

Summary coverage rate:
  lines......: 94.5% (3016 of 3191 lines)
  functions..: 72.9% (1239 of 1700 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/realtime/server.ex                                          |99.2%    132|97.8%    45|    -      0
  lib/skate_web/channels/vehicle_channel.ex                       | 100%     20|80.0%    10|    -      0
  lib/skate_web/channels/vehicles_channel.ex                      |95.8%     24|81.8%    11|    -      0
  lib/skate_web/channels/vehicles_search_channel.ex               |92.3%     26| 100%    12|    -      0

Download coverage report

@lemald lemald merged commit a351fd7 into main Jan 5, 2024
9 checks passed
@lemald lemald deleted the lem-remove-old-maps-code branch January 5, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

@joshlarson joshlarson joshlarson approved these changes

Assignees
No one assigned
Labels
deploy-to-dev-green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemald @joshlarson @firestack