Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ex/test/conn-case): make default user dynamic from factory #2875

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented Oct 22, 2024

#2874

There are a few tests which assume what user information they're going to get, but #2864 "revealed" that we hardcode the user for ConnCase, but with #2873 we can now generate dynamic users, so this fixes the tests so that we can dynamically create users.

Depends on:

@firestack firestack force-pushed the kf/feat/dynamic-conn-case-user branch 2 times, most recently from 012c023 to 372eba7 Compare October 25, 2024 15:06
@firestack firestack force-pushed the kf/feat/dynamic-conn-case-user branch 2 times, most recently from 6d073ae to dd665cd Compare November 4, 2024 15:24
@firestack firestack marked this pull request as ready for review November 7, 2024 14:21
@firestack firestack requested a review from a team as a code owner November 7, 2024 14:21
@firestack firestack force-pushed the kf/feat/dynamic-conn-case-user branch from dd665cd to cca18ea Compare November 7, 2024 14:25
@firestack firestack changed the base branch from main to kf/feat/fix-user-tests November 7, 2024 14:25
@firestack firestack merged commit 403e1f5 into kf/feat/fix-user-tests Nov 7, 2024
15 checks passed
@firestack firestack deleted the kf/feat/dynamic-conn-case-user branch November 7, 2024 15:56
@firestack
Copy link
Member Author

oops 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant