perf: 댓글이 보여지는 부분에 memo를 적용하라 #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
saseungmin
commented
Feb 5, 2023
saseungmin
commented
- 상세 페이지의 댓글에 React.memo를 적용하여 성능 최적화
- 상세 페이지의 댓글에 React.memo를 적용하여 성능 최적화
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against d14bde2 Route: No significant changes found Dynamic import: No significant changes found |
|
⚡️ 1 Lighthouse report!
⚡️ 2 Lighthouse report!
⚡️ 3 Lighthouse report!
|
saseungmin
commented
Feb 5, 2023
Comment on lines
+22
to
+28
| const commentViewPropsAreEqual = (prevProps: Props, nextProps: Props) => ( | ||
| prevProps.comment.commentId === nextProps.comment.commentId | ||
| && prevProps.userUid === nextProps.userUid | ||
| && prevProps.onRemove === nextProps.onRemove | ||
| && prevProps.comment.writer.uid === nextProps.comment.writer.uid | ||
| && prevProps.comment.groupId === nextProps.comment.groupId | ||
| ); |
There was a problem hiding this comment.
댓글이 보여지는 각 아이템을 memo로 감싸주어 성능 최적화를 하기 위해서 props비교를 수동으로 적용
react는 얕은 비교로 비교한다
| export default memo(TagsBar); | ||
| export default TagsBar; |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.