Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce more checks #108

Merged
merged 22 commits into from
Jan 8, 2025
Merged

enforce more checks #108

merged 22 commits into from
Jan 8, 2025

Conversation

mcocdawc
Copy link
Owner

@mcocdawc mcocdawc commented Jan 8, 2025

  • actually enforce ruff check
  • actually enforce mypy

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (2f919de) to head (60ba9e7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/chemcoord/configuration.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #108       +/-   ##
==========================================
- Coverage   66.31%   0.00%   -66.32%     
==========================================
  Files          27      27               
  Lines        2808    2787       -21     
==========================================
- Hits         1862       0     -1862     
- Misses        946    2787     +1841     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcocdawc mcocdawc merged commit dace010 into master Jan 8, 2025
7 of 9 checks passed
@mcocdawc mcocdawc deleted the enforce_more_checks branch January 8, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant