Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numpy functions #116

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Use numpy functions #116

merged 5 commits into from
Jan 13, 2025

Conversation

mcocdawc
Copy link
Owner

There are a few numpy functions such as numpy.cross which were not available for numba when I wrote the package.
With this PR the corresponding numpy functions are used instead of the custom ones.

Fixes #113

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (9165c76) to head (977778d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ord/_cartesian_coordinates/_cart_transformation.py 0.00% 7 Missing ⚠️
...oord/_internal_coordinates/_zmat_transformation.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #116   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          29      29           
  Lines        2783    2763   -20     
======================================
+ Misses       2783    2763   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcocdawc mcocdawc merged commit eae7421 into master Jan 13, 2025
9 checks passed
@mcocdawc mcocdawc deleted the use_numpy_functions branch January 13, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace jitted functions with numpy where possible
1 participant