Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #123

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Small fixes #123

wants to merge 4 commits into from

Conversation

mcocdawc
Copy link
Owner

  • use arctan(x, y) == arctan(x / r, y / r) for non-zero r and get rid of unnecessary division. Spotted by @nwhel
  • added missing rst files for the new pyscf conversion methods.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (651ddc0) to head (0848851).

Files with missing lines Patch % Lines
...ord/_cartesian_coordinates/_cart_transformation.py 0.00% 1 Missing ⚠️
...oord/_cartesian_coordinates/_cartesian_class_io.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #123   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          29      29           
  Lines        2761    2761           
======================================
  Misses       2761    2761           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant