Skip APC storage test if apcu extension is not enabled (as Travis won…

…'t cooperate)
mcoirault · Feb 4, 2021 · ecc416f · ecc416f
1 parent 6c7a01b
commit ecc416f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/StorageAdapterFactory.php b/src/StorageAdapterFactory.php
@@ -17,6 +17,8 @@ class StorageAdapterFactory
      * @param array $config
      *
      * @return Adapter
+     *
+     * @throws \Prometheus\Exception\StorageException
      */
     public function make($driver, array $config = [])
     {

diff --git a/tests/StorageAdapterFactoryTest.php b/tests/StorageAdapterFactoryTest.php
@@ -3,6 +3,7 @@
 namespace Tests;
 
 use PHPUnit\Framework\TestCase;
+use Prometheus\Exception\StorageException;
 use Prometheus\Storage\APC;
 use Prometheus\Storage\InMemory;
 use Prometheus\Storage\Redis;
@@ -20,7 +21,12 @@ public function testMakeMemoryAdapter()
     public function testMakeApcAdapter()
     {
         $factory = new StorageAdapterFactory();
-        $adapter = $factory->make('apc');
+        try {
+            $adapter = $factory->make('apc');
+        } catch (StorageException $exception) {
+            $this->markTestSkipped("APCu not enabled? Skipping test");
+            return;
+        }
         $this->assertInstanceOf(APC::class, $adapter);
     }