Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly mention that Safari does not support custom built-ins #34947

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Explicitly mention that Safari does not support custom built-ins #34947

merged 1 commit into from
Jul 21, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #30968. #33898 already did some work, but the note could be much more explicit.

@Josh-Cena Josh-Cena requested review from a team as code owners July 21, 2024 05:21
@Josh-Cena Josh-Cena requested review from wbamberg and estelle and removed request for a team July 21, 2024 05:21
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jul 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/HTML/Global_attributes/is
Title: is

sideshowbarker
sideshowbarker approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sideshowbarker sideshowbarker merged commit 344f7e6 into mdn:main Jul 21, 2024
7 checks passed
@Josh-Cena Josh-Cena deleted the safari-built-in branch July 21, 2024 13:36
@wbamberg wbamberg mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
2 participants
@Josh-Cena @sideshowbarker