Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valueAsDate: unsupported on Chrome for datetime-local #36815

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Nov 15, 2024

@simon04 simon04 requested a review from a team as a code owner November 15, 2024 21:57
@simon04 simon04 requested review from wbamberg and removed request for a team November 15, 2024 21:57
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/API/HTMLInputElement/valueAsDate
Title: HTMLInputElement: valueAsDate property

(comment last updated: 2025-01-24 04:11:59)

@wbamberg
Copy link
Collaborator

Thanks for your PR, and sorry to be slow reviewing. We try to avoid making statements about specific browser support in the body of MDN pages, and instead represent that using BCD. So I think it would be better to add a subfeature to the compat data for this method (https://github.com/mdn/browser-compat-data/blob/31a53d119ed35cb9c97385b68c2ef15c784fcd92/api/HTMLInputElement.json#L3048) to the effect that it isn't supported in Chromium for datetime-local inputs.

@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Dec 31, 2024
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jan 24, 2025
@Josh-Cena
Copy link
Member

Josh-Cena commented Jan 24, 2025

While I agree that specific browser support information should live in BCD, the content should be greatly expanded because there are a lot of footguns here. @wbamberg do you think the current version looks fine?

@Josh-Cena Josh-Cena removed the awaiting response Awaiting for author to address review/feedback label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants