Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default behaviour of label_line_ends #38

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Nov 16, 2023

Purpose

Modifies the behaviour so that if no labels are passed to label_line_ends it will only add labels to lines whose labels don't begin with an underscore. This means label_line_ends will avoid labeling lines that don't have useful labels since matplotlib gives all lines default labels that start with underscores (e.g "_child0").

Example

Previous behaviour:
image

New behaviour:
image

Expected time until merged

1 day

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner November 16, 2023 04:37
@A-CGray A-CGray requested a review from eytanadler November 16, 2023 04:37
@A-CGray A-CGray changed the title Update utils.py Improve default behaviour of label_line_ends Nov 16, 2023
@eytanadler eytanadler merged commit 2c7bc26 into main Nov 16, 2023
18 checks passed
@eytanadler eytanadler deleted the A-CGray-patch-1 branch November 17, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants