Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel snstop #420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

parallel snstop #420

wants to merge 1 commit into from

Conversation

awccopp
Copy link

@awccopp awccopp commented Dec 17, 2024

Purpose

The purpose of this PR is to parallelize the SNSTOP user callback function.
See #417 for commit history.
A --timeout option has been added to the testflo arguments to avoid tests to hang.

Expected time until merged

1 month

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tests were added to ensure other processors are calling the snstop function.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

* parallel snstop

* formatting fixes

* added comments

* added test - does it make sense?

* fixed MPI check

* actually fixing MPI check

* iSort fix

* maybe this time the test will be skipped?

* maybe like this?

* what about this

* cleanup

* add timeout option to testflo

* rerun tests

* updated test with send/receive

---------

Co-authored-by: Marco Mangano <[email protected]>
@awccopp awccopp requested a review from a team as a code owner December 17, 2024 20:03
@awccopp awccopp requested review from lamkina and ArshSaja December 17, 2024 20:03
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.97%. Comparing base (f66e9fb) to head (e4fd7b1).

Files with missing lines Patch % Lines
pyoptsparse/pyOpt_optimizer.py 0.00% 5 Missing ⚠️
pyoptsparse/pySNOPT/pySNOPT.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #420       +/-   ##
===========================================
+ Coverage   74.98%   85.97%   +10.98%     
===========================================
  Files          22       22               
  Lines        3338     3358       +20     
===========================================
+ Hits         2503     2887      +384     
+ Misses        835      471      -364     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcomangano marcomangano changed the title parallel snstop (#417) parallel snstop Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant