fix: Address Ingredients Parser UX overflow issues on mobile #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if this should have a general "errors" or "Add missing" prefix when errors.any? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before
Desktop was ok
But mobile cropped error messages if there was more than one or they were long
After:
Which issue(s) this PR fixes:
#4954
Special notes for your reviewer:
This has a slight tradeoff in that the existing call to action ("Create") now relies on the user understanding what the + icon means, unless they hover over and read the title attribute.
The use of
flex-wrapalso looks a bit stupid, but the alternative was a list group; which looked bad on desktop.If the CSS framework has a btn-group-vertical on small screens class; I couldnt find it.
Testing
Tested locally, w/Chrome dev tools for mobile UX.