fix: Shorten Indexes #5045
Merged
fix: Shorten Indexes #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
(REQUIRED)
We index some properties that can get arbitrarily long (e.g. the recipe description). This breaks on PSQL: https://www.postgresql.org/docs/current/btree.html
This PR caps all normalized properties to 255 characters, and removes the index for instruction text. 255 characters is probably aggressive, but the only real downside to this is in searching recipes for text in descriptions longer than this paragraph.
The migration also retroactively truncates normalized properties that were too long, so the data should be in a healthy state immediately.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3181
Fixes #5041
Testing
(fill-in or delete this section)
Ran the migration manually