Check stderr when running agent #142
Conversation
Considering a successful command execution when return value is zero, no error, and stderr is empy as well
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -127,7 +127,7 @@ func (e *Executer) runWithRetry(ctx context.Context, uid types.UID, command []st | |||
| ctxWithTimeout, cancel := context.WithTimeout(ctx, timeout) | |||
| defer cancel() | |||
| stdout, stderr, faErr = e.runner(ctxWithTimeout, command) | |||
| if faErr == nil { | |||
| if faErr == nil && stderr == "" { | |||
There was a problem hiding this comment.
stderr stream isn't an indication for an actual error!
e.g. curl uses stderr for verbose info, and stdout for the actual result
/hold
|
@razo7: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close |
|
@slintes: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
Considering a successful command execution when the return value is zero, no error, and stderr is empty as well.
Changes made
Which issue(s) this PR fixes
Fixes (somehow) ECOPROJECT-1938
Test plan