Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Credentials Secret #158

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Oct 15, 2024

Why we need this PR

  • Don't use plaintext values of credentials inside CR spec. Fetch them from a secret.

Changes made

  • Update FenceAgentsRemediation CRD with CredentialParameters []ParameterName to list the parameters that we gather their values from a secret.

Which issue(s) this PR fixes

Test plan

  • New unit tests for buildFenceAgentParams function

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Oct 15, 2024

/test 4.15-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

@razo7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.15-openshift-e2e 38faff0 link true /test 4.15-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@razo7 razo7 force-pushed the fetch-credentials-secret branch from 38faff0 to ab98377 Compare December 9, 2024 10:03
razo7 added 3 commits January 12, 2025 16:39
Use the first apperance of agent's parameter and allow adding the action parameter with value reboot while processing the parameters at buildFenceAgentParams function. Fix missing event print and improve comments
The field will be used to identify the parameters we fetch from Kubernetes Secret
User needs to create a secret with the name of the unhealthy node with all the credential parameters, and values, so FAR pod can fetch them when building the agent command
@razo7 razo7 force-pushed the fetch-credentials-secret branch from de00fa0 to dce8e24 Compare January 12, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant