-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Credentials Secret #158
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test 4.15-openshift-e2e |
@razo7: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
38faff0
to
ab98377
Compare
Use the first apperance of agent's parameter and allow adding the action parameter with value reboot while processing the parameters at buildFenceAgentParams function. Fix missing event print and improve comments
The field will be used to identify the parameters we fetch from Kubernetes Secret
User needs to create a secret with the name of the unhealthy node with all the credential parameters, and values, so FAR pod can fetch them when building the agent command
de00fa0
to
dce8e24
Compare
Why we need this PR
Changes made
CredentialParameters []ParameterName
to list the parameters that we gather their values from a secret.Which issue(s) this PR fixes
Test plan
buildFenceAgentParams
function