Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify FAR Supported Agents #167

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Dec 31, 2024

Why we need this PR

FAR is doing power-based fencing (node is power-cycled, reset, or turned off to prevent it from issuing I/Os), and 7 non-power-based agents are included in FAR dockerfile. Thus, we can remove them and add 4 new supported agents.

Changes made

  • Exclude 7 non-power-based agents from installation
  • Include 3 RHEL-supported agents

Which issue(s) this PR fixes

ECOPROJECT-2081 & ECOPROJECT-1998

Test plan

  • Add webhook test for the supported agents

Exclude 7 non power-based agents from installation
Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Include 3 supported agents
@razo7 razo7 force-pushed the modify-agents-list branch from c7aff01 to 8687875 Compare December 31, 2024 15:18
@razo7
Copy link
Member Author

razo7 commented Jan 1, 2025

/test 4.17-openshift-e2e
/test 4.18-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Jan 1, 2025

@razo7: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-openshift-e2e 8687875 link true /test 4.17-openshift-e2e
ci/prow/4.18-openshift-e2e 8687875 link true /test 4.18-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant