ECOPROJECT-1829

Verify that Remediation started event isn't spammed Signed-off-by: Michael Shitrit <[email protected]>
medik8s · Jan 15, 2024 · 953ded5 · 953ded5
1 parent af81a44
commit 953ded5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/controllers/selfnoderemediation_controller.go b/controllers/selfnoderemediation_controller.go
@@ -174,7 +174,11 @@ func (r *SelfNodeRemediationReconciler) Reconcile(ctx context.Context, req ctrl.
 		r.logger.Error(err, "failed to get SNR")
 		return ctrl.Result{}, err
 	}
-	events.RemediationStarted(r.Recorder, snr)
+
+	//used as an indication not to spam the event
+	if isFinalizerAlreadyAdded := controllerutil.ContainsFinalizer(snr, SNRFinalizer); !isFinalizerAlreadyAdded {
+		events.RemediationStarted(r.Recorder, snr)
+	}
 
 	defer func() {
 		if updateErr := r.updateSnrStatus(ctx, snr); updateErr != nil {

diff --git a/controllers/tests/controller/selfnoderemediation_controller_test.go b/controllers/tests/controller/selfnoderemediation_controller_test.go
@@ -173,7 +173,7 @@ var _ = Describe("SNR Controller", func() {
 			It("Remediation flow", func() {
 				node := verifyNodeIsUnschedulable()
 
-				verifyEvent("Normal", "RemediationCreated", "Remediation started")
+				verifyEvent("Normal", "RemediationStarted", "[remediation] Remediation started")
 
 				verifyEvent("Normal", "MarkUnschedulable", "Remediation process - unhealthy node marked as unschedulable")