-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs and events fixes #174
Conversation
…erviceTaint Remediation strategy" Signed-off-by: Michael Shitrit <[email protected]>
…ackages version change Signed-off-by: Michael Shitrit <[email protected]>
Use common events and create an event signaling remediation is finished Signed-off-by: Michael Shitrit <[email protected]>
Verify that Remediation started event isn't spammed Signed-off-by: Michael Shitrit <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test 4.14-openshift-e2e |
/lgtm /hold |
/unhold |
@@ -483,6 +485,7 @@ func (r *SelfNodeRemediationReconciler) recoverNode(node *v1.Node, snr *v1alpha1 | |||
return ctrl.Result{}, err | |||
} | |||
r.Recorder.Event(snr, eventTypeNormal, eventReasonRemoveFinalizer, "Remediation process - remove finalizer from snr") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use events.NormalEvent
from common
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC the common events PR have been added after SNR events PR was merged. I guess we didn't update SNR with the common events API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asking becase in the line below we use events.RemediationFinished
, which should come from the common events API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, TBH I didn't think of that .
I've only considered the "special" events.
I'll update in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here: #178
ECOPROJECT-1826, ECOPROJECT-1827, ECOPROJECT-1829
Fixing some minor bugs improving SNR logs and events