Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs and events fixes #174

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Jan 15, 2024

ECOPROJECT-1826, ECOPROJECT-1827, ECOPROJECT-1829
Fixing some minor bugs improving SNR logs and events

…erviceTaint Remediation strategy"

Signed-off-by: Michael Shitrit <[email protected]>
…ackages version change

Signed-off-by: Michael Shitrit <[email protected]>
Use common events and create an event signaling remediation is finished

Signed-off-by: Michael Shitrit <[email protected]>
Verify that Remediation started event isn't spammed

Signed-off-by: Michael Shitrit <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member Author

/test 4.14-openshift-e2e

@mshitrit mshitrit changed the title [WIP] Logs and events fixes Logs and events fixes Jan 15, 2024
@razo7
Copy link
Member

razo7 commented Jan 15, 2024

/lgtm
It surprises me that adding the finalizer is not one of the first things SNR does, but when it adds later then your code changes make sense :)

/hold
Giving others a chance to get more reviews (feel free to un-hold)

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
@mshitrit mshitrit marked this pull request as ready for review January 17, 2024 06:48
@openshift-ci openshift-ci bot requested review from beekhof and clobrano January 17, 2024 06:48
@mshitrit
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit c6720c7 into medik8s:main Jan 17, 2024
18 checks passed
@@ -483,6 +485,7 @@ func (r *SelfNodeRemediationReconciler) recoverNode(node *v1.Node, snr *v1alpha1
return ctrl.Result{}, err
}
r.Recorder.Event(snr, eventTypeNormal, eventReasonRemoveFinalizer, "Remediation process - remove finalizer from snr")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use events.NormalEvent from common?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the common events PR have been added after SNR events PR was merged. I guess we didn't update SNR with the common events API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asking becase in the line below we use events.RemediationFinished, which should come from the common events API

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, TBH I didn't think of that .
I've only considered the "special" events.
I'll update in another PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here: #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants