Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean operator start errors due to update conflict #175

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Clean operator start errors due to update conflict #175

merged 2 commits into from
Jan 17, 2024

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Jan 15, 2024 •
edited by openshift-ci bot
Loading

ECOPROJECT-1828
Some log errors show on operator start due to a conflict of updating the ds

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member Author

/test 4.14-openshift-e2e

1 similar comment
@mshitrit
Copy link
Member Author

/test 4.14-openshift-e2e

@slintes
Copy link
Member

slintes commented Jan 16, 2024

retriggered failed build job, is it flaky? 🤔

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2024
@mshitrit
Copy link
Member Author

mshitrit commented Jan 17, 2024 •
edited
Loading

retriggered failed build job, is it flaky? 🤔

Yep.
I've mapped several flaky tests, planning soon another PR for that.

[edit]
Here it is: #176

@mshitrit mshitrit marked this pull request as ready for review January 17, 2024 07:03
@openshift-ci openshift-ci bot requested review from beekhof and clobrano January 17, 2024 07:04
@mshitrit mshitrit changed the title [WIP] Clean operator start errors due to update conflict Clean operator start errors due to update conflict Jan 17, 2024
@mshitrit
Copy link
Member Author

/test 4.13-openshift-e2e

@mshitrit
Copy link
Member Author

/retest

2 similar comments
@mshitrit
Copy link
Member Author

/retest

@mshitrit
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 55ff339 into medik8s:main Jan 17, 2024
18 checks passed
@mshitrit mshitrit deleted the daemonset-sync-log-error branch June 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slintes slintes slintes left review comments

@beekhof beekhof Awaiting requested review from beekhof

@clobrano clobrano Awaiting requested review from clobrano

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshitrit @slintes