Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list and watch permission for templates to aggregated role #181

Merged

Conversation

slintes
Copy link
Member

@slintes slintes commented Jan 30, 2024

Needed by NHC in order to react on template deletion

ECOPROJECT-1857

Needed by NHC in order to react on template deletion

Signed-off-by: Marc Sluiter <[email protected]>
@openshift-ci openshift-ci bot requested review from beekhof and mshitrit January 30, 2024 10:09
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member

/lgtm

@slintes
Copy link
Member Author

slintes commented Jan 30, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 7e88291 into medik8s:main Jan 30, 2024
18 checks passed
@slintes slintes deleted the extend-template-permission branch June 11, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants