-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating "Automatic" log message #184
Updating "Automatic" log message #184
Conversation
… than we loose connectivity after reboot, missing this log. Signed-off-by: Michael Shitrit <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: Michael Shitrit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: we could put the runtime strategy into an annotation, so it's visible on the CR, and we don't need to spam the logs with it in each reconcile?
Can also be done in a follow up...
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Maybe, TBH I am not even so sure that we should even print this log to begin with. I'm not sure what's the proper balance from a user perspective between: I'm also a bit worried from followup bugs (when we chance the Automatic selection/ or when run on different ocp version) such as the runtime annotation used to be X and now it's Y |
Maybe it's fair to discuss how much info to reveal to the user. But we also need it ourself for debugging, not?
Actually I see this as an pro argument for the annotation. In case SNR or the cluster updates during remediation, it would be bad to switch from one strategy to another one, not? The cleanup would not match anymore. With the annotation we can ensure that we use the same strategy for the whole remediation process. |
/test 4.14-openshift-e2e |
Sure SGTM.
I'm not sure. |
/test 4.13-test |
/unhold |
ECOPROJECT-1862