Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove finilizer when deleted SNR is marked with NHC Timeout #247

Merged

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Jan 7, 2025

Why we need this PR

SNR should allow removal of redundant remediations - a remediation of a node that no longer exist since MDR deleted the node and triggered a provisioning of a new one

Changes made

When SNR detects a remediation that is both deleted and marked as Timeout by NHC it will remove the finilizer

Which issue(s) this PR fixes

ECOPROJECT-2489

Test plan

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 7, 2025
@mshitrit mshitrit changed the title Remove finilizer when deleted SNR is marked with NHC Timeout [WIP] Remove finilizer when deleted SNR is marked with NHC Timeout Jan 7, 2025
@mshitrit
Copy link
Member Author

mshitrit commented Jan 7, 2025

/test ?

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

@mshitrit: The following commands are available to trigger required jobs:

/test 4.14-ci-bundle-self-node-remediation-bundle
/test 4.14-images
/test 4.14-openshift-e2e
/test 4.14-test
/test 4.15-ci-bundle-self-node-remediation-bundle
/test 4.15-images
/test 4.15-openshift-e2e
/test 4.15-test
/test 4.16-ci-bundle-self-node-remediation-bundle
/test 4.16-images
/test 4.16-openshift-e2e
/test 4.16-test
/test 4.17-ci-bundle-self-node-remediation-bundle
/test 4.17-images
/test 4.17-openshift-e2e
/test 4.17-test
/test 4.18-ci-bundle-self-node-remediation-bundle
/test 4.18-images
/test 4.18-openshift-e2e
/test 4.18-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mshitrit
Copy link
Member Author

mshitrit commented Jan 7, 2025

/test 4.17-openshift-e2e

@mshitrit mshitrit changed the title [WIP] Remove finilizer when deleted SNR is marked with NHC Timeout Remove finilizer when deleted SNR is marked with NHC Timeout Jan 8, 2025
@slintes
Copy link
Member

slintes commented Jan 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2025
@slintes slintes marked this pull request as ready for review January 9, 2025 11:53
@openshift-ci openshift-ci bot requested review from clobrano and slintes January 9, 2025 11:53
@slintes
Copy link
Member

slintes commented Jan 9, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 4e07717 into medik8s:main Jan 9, 2025
22 checks passed
@slintes
Copy link
Member

slintes commented Jan 9, 2025

prepare backport in case we want to release this in the upcoming release...

/cherry-pick release-0.10

@openshift-cherrypick-robot

@slintes: new pull request created: #248

In response to this:

prepare backport in case we want to release this in the upcoming release...

/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants