-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove finilizer when deleted SNR is marked with NHC Timeout #247
Remove finilizer when deleted SNR is marked with NHC Timeout #247
Conversation
Signed-off-by: Michael Shitrit <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@mshitrit: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test 4.17-openshift-e2e |
/lgtm |
/retest |
prepare backport in case we want to release this in the upcoming release... /cherry-pick release-0.10 |
@slintes: new pull request created: #248 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
SNR should allow removal of redundant remediations - a remediation of a node that no longer exist since MDR deleted the node and triggered a provisioning of a new one
Changes made
When SNR detects a remediation that is both deleted and marked as Timeout by NHC it will remove the finilizer
Which issue(s) this PR fixes
ECOPROJECT-2489
Test plan