fix(op-node): Execute only part of the initialReset function each time #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claymega
requested review from
yangl1996,
SilasZhr,
Troublor and
bruce-megaeth
claymega
changed the title
| if d.pipeline.pipeLineIsInitialReset && | ||
| d.pipeline.pipelineInitialResetNextTime.Before(time.Now()) { | ||
| d.emitter.Emit(PipelineStepEvent{PendingSafe: d.pipeline.pipelineInitialResetNextPendingSafe}) | ||
| } |
There was a problem hiding this comment.
If true, continue to execute the previous initialReset logic, if false, then no logic is executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is for fixing event dead loop when restarting op-node and the unsafe/safe difference is large.
Problem: When the unsafe/safe difference is large, the restart op-node will call
initialReset(), If this function call takes too long, thepipelineHandlerwill be blocked and unable to consume events inpipeline queue(theexecutorkeep adding events topipeline queue). ThepipelineHandlerwill also generate events when executing the event consumption logic.