Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ntlm, acl examples to security directory #1501

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Move ntlm, acl examples to security directory #1501

wants to merge 3 commits into from

Conversation

t-burch
Copy link
Collaborator

@t-burch t-burch commented Jan 20, 2025

No description provided.

@membrane-ci-server
Copy link

This pull request needs "/ok-to-test" from an authorized committer.

@t-burch t-burch requested a review from predic8 January 20, 2025 13:00
@t-burch t-burch linked an issue Jan 20, 2025 that may be closed by this pull request
move ntlm and acl example to security subdir #1471
Open
@t-burch
Copy link
Collaborator Author

t-burch commented Jan 20, 2025

/ok-to-test

@rrayst
Copy link
Contributor

rrayst commented Jan 21, 2025

Please note that the starter scripts (*.sh/*.bat) were moved to a subdirectory on a lower level. They contain ../../..\.. which needs to be adjusted.

rrayst
rrayst requested changes Jan 21, 2025
View reviewed changes
distribution/examples/security/acl/service-proxy.bat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. this file contains ..\..

Copy link
Collaborator Author

@t-burch t-burch Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait until we replace all scripts with the new path independent versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrayst rrayst rrayst requested changes

@predic8 predic8 Awaiting requested review from predic8

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move ntlm and acl example to security subdir
2 participants
@t-burch @rrayst