[WC-2512]: Add loading state to datagrid-web #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelreichert
changed the title
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
2 times, most recently
from
fa7a50c to
63f80d8
Compare
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
2 times, most recently
from
83ff96a to
ba7059c
Compare
iobuhov
requested changes
Oct 3, 2024
packages/pluggableWidgets/datagrid-web/src/components/loader/TableSkeleton.tsx
Outdated
Show resolved
Hide resolved
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
3 times, most recently
from
7df938c to
b452cf4
Compare
iobuhov
reviewed
Oct 11, 2024
|
I'll approve after rebase. |
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
from
b452cf4 to
6cdec58
Compare
iobuhov
reviewed
Oct 14, 2024
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
from
8d32220 to
ae9b1b9
Compare
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
from
ae9b1b9 to
900518d
Compare
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
3 times, most recently
from
f9c081c to
3197385
Compare
iobuhov
reviewed
Oct 23, 2024
iobuhov
requested changes
Oct 23, 2024
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
from
d0260db to
884fd01
Compare
iobuhov
reviewed
Oct 24, 2024
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss
Show resolved
Hide resolved
leonardomendix
previously approved these changes
Oct 28, 2024
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
from
62448b6 to
81a3bff
Compare
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
from
81a3bff to
e1b02fd
Compare
samuelreichert
force-pushed
the
feat/WC-2512-dg2-loading-state
branch
from
7fe0802 to
043bc52
Compare
leonardomendix
approved these changes
Nov 4, 2024
iobuhov
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Add a loading state to datagrid-web, to run every time datasource is changing, it can be: When paginating, when filtering, on first datagrid load.
Add the property
loading typewhere can be selected option "Skeleton" or "Spinner" loader.By default, "Spinner" will be selected.
The loading state will use the loading type to show a component to indicate the user that the content is loading, or changing.
Screenshots
Spinner loader
Skeleton loader
